Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin busybox to 1.28 #9901

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Pin busybox to 1.28 #9901

merged 1 commit into from
Aug 20, 2018

Conversation

marshallford
Copy link
Contributor

In busybox:latest, nslookup does not work in K8s. See: https://bugs.busybox.net/show_bug.cgi?id=11161. This inconsistency makes following the Debugging DNS Resolution guide quite confusing/difficult (Is my cluster wonky or the image I'm testing with?). According to this comment in the Busybox Docker repo, this change was intentional upstream. At least for the time being I suggest we pin the Busybox version used to prevent confusion.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a116cff

https://deploy-preview-9901--kubernetes-io-master-staging.netlify.com

@marshallford
Copy link
Contributor Author

Registered.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2018
@zacharysarah
Copy link
Contributor

@marshallford 👋 I'm willing to approve this PR, with the understanding that I'll point any issues about busybox versions to you.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 973e6b8 into kubernetes:master Aug 20, 2018
@chenopis chenopis added this to the WtD Cincy milestone Aug 20, 2018
@marshallford marshallford deleted the marshallford-patch-1 branch August 21, 2018 00:50
rosti pushed a commit to rosti/website that referenced this pull request Aug 23, 2018
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
voelzmo added a commit to voelzmo/website that referenced this pull request Mar 11, 2019
* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28
* remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
k8s-ci-robot pushed a commit that referenced this pull request Mar 12, 2019
* Similarly to #9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28
* remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Similarly to kubernetes#9901 pin busybox image to 1.28. Although https://bugs.busybox.net/show_bug.cgi?id=11161 is closed, this still doesn't work on images > 1.28
* remove `/bin/sh` from the command to be executed on busybox, this leads to `/bin/sh: can't open 'nslookup': No such file or directory`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants